-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add testmon in pytest #1209
Merged
gaurav274
merged 13 commits into
staging
from
1200-use-pytest-testmon-to-run-the-long-integration-tests-that-are-affected-by-the-open-pr
Sep 26, 2023
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1303023
update testmon
jiashenC c2443af
Enable testmon for long intergration test on changed files.
xzdandy 9f84c04
Fix sklearn long intergration tests
xzdandy 63c680f
We save the .testmondata on staging branch for python3.10 and ray
xzdandy 280b2b6
Updated config.yml
xzdandy 63cebb6
Add sklearn dependency
xzdandy 7303de1
Merge branch '1200-use-pytest-testmon-to-run-the-long-integration-tes…
xzdandy 739c128
Make sklearn and ludwig has different name.
xzdandy 38ea899
Only load cache for open PR
xzdandy 5153fa2
Simplify the circle ci config
xzdandy 64e7dc7
Updated config.yml
xzdandy 84feaee
Linter
xzdandy 868823c
Merge branch '1200-use-pytest-testmon-to-run-the-long-integration-tes…
xzdandy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not something critical, shall we only restore the cache for the open PR long integration cached test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I tried a different way to simplify the circle ci config. Please take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I meant it is currently restoring the cache for any test. Is that expected? Do we want to rerun everything for
staging
andmaster
? Or we should run only affected as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we should run all the testcases for staging/master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--testmon-noselect
for all staging and master.when condition
to make circle ci simple. PS: I can not make when condition work for restoring cache.