feat: read Taskfiles from stdin #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
approved these changes
Feb 22, 2024
|
@andreynering Small change in 7abbc15 as per this conversation: #655 (comment). Please let me know if you're ok with this? @brianbraunstein Could you please give the changes a go and see if they work as you expect |
|
@pd93 Looks fine to me 👍 |
pd93
added a commit
that referenced
this pull request
Feb 22, 2024
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #655
Adds a new
StdinNodethat implements theNodeinterface. This is a special-case Node that only gets created if Task detects bytes in stdin when starting. I've refactored the way we create "root" nodes (i.e. nodes without parents) in order to do this. I think the result is a bit nicer and lays the groundwork for root remote nodes too.I also had to resolve an issue in the reader where an included file's
BaseDirwas only being set forFileNode. I have added aBaseDir()method to theNodeinterface and this will now be added by any node that returns a non-empty string when calling this method.Lastly, I have updated the docs with a section on reading from stdin. This also includes a commit that adds some missing syntax highlighters to our docs site and standardises the
```shellcode blocks language ID.