Add containerSecurityContext to components #1304
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
This PR attempts to address the issue raised here : #1286
Basically, it's desirable under some circumstances to allow the user to customize
.spec.container.securityContext
, to meet compliance requirements (such as apply seccomp policy).An objection raised in #1286 was that allowing custom securityContext could cause breakage, since some of the apps' UIDs are hard-coded in their docker files. To this end, I've avoided changing the pod securityContexts, and focused only on adding the ability to augment the container securityContext.
This means that in the case of core, for example, the following hard-coded securityContext still applies:
But a user could pass this in
values.yaml
:.. which would greatly improve our compliance / security posture, without impacting the intended effect of the hard-coded pod securityContext.