-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security context #1695
Add security context #1695
Conversation
I have one comment. As far as I can see, database and redis use different uids and gids from the rest of the components, so I guess global
|
Hi @Kajot-dev , Thanks for your review and sorry for the late response since i just came back from holidays. We don't expose What I initially want to write in values.yaml is a empty yaml looks like below and users could configure it on demand. Current version is just filled with a common template for convenience.
|
relevant PRs:
Thanks @Kajot-dev , @rgarcia89 @dwagelaar , @funkypenguin for all of the contributions! Let's focus on review this PR to meet several requirements. |
074a6f4
to
bb79b1b
Compare
bb79b1b
to
478756a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing in core-pre-upgrade job, the rest looks good to me
Signed-off-by: yminer <[email protected]> update for trivy and db update db-ss init container Signed-off-by: yminer <[email protected]> update core-pre-upgrade-job.yaml Signed-off-by: yminer <[email protected]> update values.yaml fix core-pre-upgrade-job typo
478756a
to
7913d7e
Compare
No description provided.