8614 regex replication filters

[WilfredAlmeida]

This PR aims to add regular expression based replication rules feature to Harbor.

Issue: 8614
Community Proposal: 221

The filter functions for regex-based filtering are defined in the src/pkg/reg/filter/artifact.go file alongside the existing filtering functions using the double star logic.

Necessary schema properties are added in the policy.go file.

The decision on the finalized approach to add the feature is discussed in the community proposal 221

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 67.40%. Comparing base (a3e1b1e) to head (97d495e).
Report is 25 commits behind head on main.

❗ Current head 97d495e differs from pull request most recent head 3206245. Consider uploading reports for the commit 3206245 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18723      +/-   ##
==========================================
- Coverage   67.45%   67.40%   -0.05%     
==========================================
  Files         996      993       -3     
  Lines      109773   109021     -752     
  Branches     2720     2763      +43     
==========================================
- Hits        74044    73490     -554     
+ Misses      31747    31574     -173     
+ Partials     3982     3957      -25     

Flag	Coverage Δ
unittests	67.40% <57.14%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/portal/src/app/shared/entities/shared.const.ts	100.00% <ø> (ø)
src/pkg/reg/model/policy.go	38.46% <50.00%> (ø)
src/pkg/reg/filter/artifact.go	67.91% <75.00%> (+5.41%)	⬆️
...ion/create-edit-rule/create-edit-rule.component.ts	33.06% <2.94%> (-2.65%)	⬇️

... and 108 files with indirect coverage changes

[WilfredAlmeida]

I am aware that there are print statements in the code. They are there for personal debugging reference and will be removed in the mergeable PR.

[WilfredAlmeida]

The latest commit edf8c20 removes some unnecessary and error causing Angular properties from the portal.

The properties are for radio input for choosing filter mode between regex & double star

[OrlinVasilev]

@Vad1mo and @wy65701436 can you review this one please :)

[OrlinVasilev]

@WilfredAlmeida please fix DCO

[WilfredAlmeida]

I'll fix the DCO issue and update here.

[Vad1mo]

some tests seem to fail, and you are missing the DCO

[WilfredAlmeida]

@Vad1mo @OrlinVasilev In between my commits, I synced my fork with the main repo. Now when I'm trying to fix DCO it's adding it to commits that are not mine.

My first commit was on May 10th and when I do a rebase its rewriting the commits of others as well.

Is there a way I can only add DCO to my commits?

[WilfredAlmeida]

@Vad1mo @OrlinVasilev I've fixed the DCO and other occurring issues. Please let me know if any more actions are required from my side.

[github-actions]

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

[kristianhaukeland]

Still relevant

[wy65701436]

@WilfredAlmeida thanks for your contribution.

To support regex in Harbor, I propose creating a shared library of regex patterns, similar to the double star we currently use. This library would apply across all Harbor functionalities, including replication and tag retention, making it easier to enable consistent functionality for tag retention.

If you’re still willing to work on this pull request, @chlins and I will do our best to assist you from a technical perspective.

[WilfredAlmeida]

Hello @wy65701436, currently I don't have the bandwidth to work this and won't be able to do so anytime soon

[wy65701436]

Thanks, @WilfredAlmeida, for your response. Given this, I believe we can temporarily close this pull request until we have someone from the community who can assist.