windows: export getProcessEntry #143
Conversation
|
This PR (HEAD: 2fb76ef) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/459039 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/459039. |
This function is currently copied in github.com/inconshreveable/mousetrap, which is widely used in projects (commonly as dependency for spf13/cobra). Until recently, mousetrap had code for backward-compatibility with old Go versions, but now that that code was removed, it's a very small wrapper around getProcessEntry. Exporting this function allows it to be an even smaller wrapper (most projects would already have golang.org/x/sys as dependency in some form or another).
thaJeztah
force-pushed
the
export_getProcessEntry
branch
from
2fb76ef to
b8275de
Compare
|
This PR (HEAD: b8275de) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/459039 to see it. Tip: You can toggle comments from me using the |
|
Message from Sebastiaan van Stijn: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/459039. |
|
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/459039. |
|
Message from Alex Brainman: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/459039. |
|
Message from Sebastiaan van Stijn: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/459039. |
This function is currently copied in github.com/inconshreveable/mousetrap, which is widely used in projects (commonly as dependency for spf13/cobra).
Until recently, mousetrap had code for backward-compatibility with old Go versions, but now that that code was removed, it's a very small wrapper around getProcessEntry. Exporting this function allows it to be an even smaller wrapper (most projects would already have golang.org/x/sys as dependency in some form or another).