remove support for go1.3 #7
Conversation
go1.4 was released 8 Years ago, so it's very unlikely anyone is still using go1.3. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This allows us to remove the buildtag comment. Also updated the other buildtags to the current go format. Doing the rename in a separate commit, to assist Git history to continue keeping track. Signed-off-by: Sebastiaan van Stijn <[email protected]>
os.Getppid() is an alias for syscall.Getppid(), which was already imported, so use it directly instead of the alias. Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
@inconshreveable PTAL 🤗 |
| if snapshot == uintptr(syscall.InvalidHandle) { | ||
| err = fmt.Errorf("CreateToolhelp32Snapshot: %v", e1) | ||
| return | ||
| func getProcessEntry(pid int) (*syscall.ProcessEntry32, error) { |
There was a problem hiding this comment.
Thanks!
FWIW, I'm considering a pull request in golang.org/x/sys to see if the maintainers there are open to exporting the equivalent function there. I'll let you know if they do (and open a PR here)
There was a problem hiding this comment.
I opened golang/sys#143 (https://go-review.googlesource.com/c/sys/+/459039) to see if the maintainers are open to exporting it 👍
|
@inconshreveable thanks! Is there anything left to do on my hand, or is this OK to be merged? If so; could you consider tagging a new release? After that I'll update some projects using it to use the new version 👍 |
|
done, tagged v1.1 |
|
@inconshreveable Thanks for merging! Erm.. would you be able to add a |
|
pushed a v1.1.0 tag, lemme know if you need anything else! |
|
Looks like we're all set, thanks! I opened spf13/cobra#1870 |
remove support for go1.3
go1.4 was released 8 Years ago, so it's very unlikely anyone is still using go1.3.
rename files to regular name, and update buildtags
This allows us to remove the buildtag comment. Also updated the other buildtags to the current go format.
remove "os" import
os.Getppid() is an alias for syscall.Getppid(), which was already imported, so use it directly instead of the alias.