Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test coverage upload dashapi #5634

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

tarasmadan
Copy link
Collaborator

@tarasmadan tarasmadan commented Dec 20, 2024

It tests the Dashboard.CreateUploadURL.
It internally calls "create_upload_url" method of the dashboard "/api" interface.
This dashboard API requires GlobalConfig.UploadBucket option to specify the bucket.
Dashboard generates the $bucket/$uuid.upload URL and returns it to the client.

@tarasmadan tarasmadan force-pushed the test_coverage_upload branch 3 times, most recently from b7a0425 to e911361 Compare December 20, 2024 11:57
Copy link
Member

@ramosian-glider ramosian-glider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is hard to understand what we are testing :)
Can you please include an example URL in the comment?

@tarasmadan
Copy link
Collaborator Author

I updated this PR description.

@tarasmadan tarasmadan requested a review from a-nogikh December 20, 2024 13:41
@tarasmadan
Copy link
Collaborator Author

#5635 to test more challenging APIs.

@tarasmadan tarasmadan added this pull request to the merge queue Dec 20, 2024
Merged via the queue into google:master with commit 9d70ccd Dec 20, 2024
17 checks passed
@tarasmadan tarasmadan deleted the test_coverage_upload branch December 21, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants