Skip to content

Commit

Permalink
Add Setting to Disable Tracing (#120)
Browse files Browse the repository at this point in the history
* fix: add setting to disable tracing

Close gh-119

* docs: document `grails.geb.tracing.enabled` setting
  • Loading branch information
matrei authored Dec 24, 2024
1 parent fa6201f commit 667a075
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 0 deletions.
12 changes: 12 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,18 @@ By default, no test recording will be performed. Here are the system properties
* possible values are `FLV` or `MP4`
* defaults to `MP4`

#### Observability and Tracing
Selenium integrates with [OpenTelemetry](https://opentelemetry.io) to support observability and tracing out of the box. By default, Selenium [enables tracing](https://www.selenium.dev/blog/2021/selenium-4-observability).

This plugin, however, **disables tracing by default** since most setups lack an OpenTelemetry collector to process the traces.

To enable tracing, set the following system property:
* `grails.geb.tracing.enabled`
* possible values are `true` or `false`
* defaults to `false`

This allows you to opt in to tracing when an OpenTelemetry collector is available.

### GebSpec

If you choose to extend `GebSpec`, you will need to have a [Selenium WebDriver](https://www.selenium.dev/documentation/webdriver/browsers/) installed that matches a browser you have installed on your system.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,15 @@ class GrailsGebSettings {
private static VncRecordingMode DEFAULT_RECORDING_MODE = VncRecordingMode.SKIP
private static VncRecordingFormat DEFAULT_RECORDING_FORMAT = VncRecordingFormat.MP4

String tracingEnabled
String recordingDirectoryName
String reportingDirectoryName
VncRecordingMode recordingMode
VncRecordingFormat recordingFormat
LocalDateTime startTime

GrailsGebSettings(LocalDateTime startTime) {
tracingEnabled = System.getProperty('grails.geb.tracing.enabled', 'false')
recordingDirectoryName = System.getProperty('grails.geb.recording.directory', 'build/gebContainer/recordings')
reportingDirectoryName = System.getProperty('grails.geb.reporting.directory', 'build/gebContainer/reports')
recordingMode = VncRecordingMode.valueOf(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ class WebDriverContainerHolder {
grailsGebSettings.recordingFormat
)
currentContainer.tap {
withEnv('SE_ENABLE_TRACING', grailsGebSettings.tracingEnabled)
withAccessToHost(true)
start()
}
Expand Down

0 comments on commit 667a075

Please sign in to comment.