Skip Starting Recording Container When Recording Mode is Set to SKIP
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbglasius
reviewed
Dec 23, 2024
| @@ -98,14 +98,11 @@ class WebDriverContainerHolder { | |||
| } | |||
|
|
|||
| currentConfiguration = specConfiguration | |||
| currentContainer = new BrowserWebDriverContainer() | |||
| if (grailsGebSettings.recordingEnabled) { | |||
There was a problem hiding this comment.
It looks like you always start the recording container
There was a problem hiding this comment.
@sbglasius If grailsGebSettings.recordingMode is set to SKIP, grailsGebSettings.isRecordingEnabled() will return false and the recordingMode on the currentContainer will not be changed. The default BrowserWebDriverContainer.recordingMode is RECORD_FAILING.
With this change, if the grailsGebSettings.recordingMode is SKIP, the BrowserWebDriverContainer.recordingMode will also be SKIP
jdaugherty
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-117