Refactor proxy list command, ensuring api-gateway Pods are included
#4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxies are also now output in deterministic order based on their proxy type, namespace and name
nathancoleman
added
area/cli
sarahalsmiller
approved these changes
Nov 18, 2024
This was referenced Nov 18, 2024
nathancoleman
added a commit
that referenced
this pull request
Nov 19, 2024
…#4426) * Refactor `proxy list` command, ensuring api-gateway Pods are included Proxies are also now output in deterministic order based on their proxy type, namespace and name * Stop printing non-JSON info to terminal when `-o json` is requested * Update test assertions to expect sorted output * Add changelog entry
nathancoleman
pushed a commit
that referenced
this pull request
Nov 19, 2024
…#4426) * Refactor `proxy list` command, ensuring api-gateway Pods are included Proxies are also now output in deterministic order based on their proxy type, namespace and name * Stop printing non-JSON info to terminal when `-o json` is requested * Update test assertions to expect sorted output * Add changelog entry
nathancoleman
pushed a commit
that referenced
this pull request
Nov 19, 2024
…are included into release/1.1.x (#4427) Refactor `proxy list` command, ensuring api-gateway Pods are included (#4426) * Refactor `proxy list` command, ensuring api-gateway Pods are included Proxies are also now output in deterministic order based on their proxy type, namespace and name * Stop printing non-JSON info to terminal when `-o json` is requested * Update test assertions to expect sorted output * Add changelog entry Co-authored-by: temp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
proxy listcommand where they were not before due to a helm chart label that wasn't present. It doesn't make sense to include this label on created API gateways since they are not actually controlled by the helm chart.How I've tested this PR
Install an assortment of gateways and mesh-injected services, verify output matches (
go run ./cli proxy list -all-namespaces, for example)How I expect reviewers to test this PR
See above
Checklist