Exposes expected number of workers to JMeter master #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoarrais
force-pushed
the
wait-for-workers
branch
from
a30eb9d to
c2dff2a
Compare
Part of the fix for hellofresh#332
thiagoarrais
force-pushed
the
wait-for-workers
branch
from
c2dff2a to
08bae14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a fix for #332. It injects the number of expected workers into the JMeter master job so that the launcher script knows for how many to wait for before starting JMeter itself.
There is a potential problem with dereferencing the pointer
*loadTest.Spec.DistributedPodswithout checking for nil, but I've assumed it'll be set becauseNewTestdataConfigMapis called prior to this function and it already seems to use it without checking.