Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: github.com/inconshreveable/mousetrap v1.1.0 #1870

Closed
wants to merge 1 commit into from

Conversation

thaJeztah
Copy link
Contributor

full diff: inconshreveable/mousetrap@v1.0.1...v1.1.0

- Removes compatibility code for go1.3
- Updates build-tag format for current go versions

full diff: inconshreveable/mousetrap@v1.0.1...v1.1.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Contributor Author

Looks like CI is broken on go1.15;

Error: ../../../go/pkg/mod/github.com/kyoh86/[email protected]/config/load.go:64:9: undefined: os.ReadFile
note: module requires Go 1.17
Error: Process completed with exit code 2.

@thaJeztah
Copy link
Contributor Author

Opened #1871

Copy link
Contributor

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marckhouzam
Copy link
Collaborator

@thaJeztah Could you rebase this to the latest main branch, we no longer run ci on go 1.15

@marckhouzam
Copy link
Collaborator

@thaJeztah Could you rebase this to the latest main branch, we no longer run ci on go 1.15

Actually, to save you time, I merged #1872 from dependabot which did the same change.

@marckhouzam marckhouzam closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants