Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new protoc-gen-alias command to allow backwards version compat #2921

Merged
merged 2 commits into from
May 15, 2024
Merged

Add new protoc-gen-alias command to allow backwards version compat #2921

merged 2 commits into from
May 15, 2024

Conversation

howardjohn
Copy link
Member

Implements istio/api#3127

@howardjohn howardjohn requested a review from a team as a code owner May 10, 2024 00:39
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label May 10, 2024
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 10, 2024
@howardjohn howardjohn mentioned this pull request May 10, 2024
Merged
keithmattix
keithmattix reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm not totally sure what's going on; the README confused me a bit. Could you clarify/update it?

cmd/protoc-gen-alias/README.md Outdated Show resolved Hide resolved
cmd/protoc-gen-alias/main.go Show resolved Hide resolved
cmd/protoc-gen-alias/main.go Show resolved Hide resolved
cmd/protoc-gen-alias/main.go Show resolved Hide resolved
@whitneygriffith whitneygriffith mentioned this pull request May 14, 2024
Merged
@howardjohn howardjohn requested a review from keithmattix May 14, 2024 22:23
@istio-testing istio-testing merged commit ab5e3a1 into istio:master May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithmattix keithmattix keithmattix approved these changes

@dhawton dhawton dhawton approved these changes

Assignees

@keithmattix keithmattix

@whitneygriffith whitneygriffith

@jacob-delgado jacob-delgado

Labels
release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@howardjohn @dhawton @keithmattix @whitneygriffith @istio-testing @jacob-delgado