Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup after upgrade #80

Merged
merged 10 commits into from
Aug 26, 2024

Remove redundant condition

8a87111
Select commit
Loading
Failed to load commit list.
Merged

Code cleanup after upgrade #80

Remove redundant condition
8a87111
Select commit
Loading
Failed to load commit list.
ci.jenkins.io / Code Coverage succeeded Aug 26, 2024 in 0s

Line Coverage: 10.64% (+0.80%), Branch Coverage: 10.00% (+6.44%)

Summary for modified lines

  • 86 lines have been modified
  • 42 lines are not covered
  • 16 lines are covered only partially

Overview by baseline

Quality Gates Summary

No active quality gates.

Details

Project coverage details

Module Coverage Package Coverage File Coverage Class Coverage Method Coverage Line Coverage Branch Coverage Instruction Coverage
🐾 Overall project 100.00% (1/1) 66.67% (6/9) 24.29% (17/70) 23.91% (22/92) 14.58% (71/487) 11.35% (208/1832) 8.79% (48/546) 10.86% (801/7374)
📈 Overall project (difference to reference job) +0.00% +0.00% +0.00% +0.76% ⬆️ +0.29% ⬆️ +0.16% ⬆️ +0.21% ⬆️ +0.13% ⬆️
🐾 Modified files 100.00% (1/1) 57.14% (4/7) 37.50% (6/16) 34.38% (11/32) 13.27% (30/226) 9.84% (87/884) 3.56% (11/309) 7.55% (269/3561)
📈 Modified files (difference to reference job) n/a n/a n/a n/a n/a +0.21% ⬆️ +0.30% ⬆️ n/a
🐾 Modified code lines 100.00% (1/1) 14.29% (1/7) 6.25% (1/16) n/a n/a 10.64% (5/47) 10.00% (3/30) n/a
📈 Modified code lines (difference to modified files) n/a n/a n/a n/a n/a +0.80% ⬆️ +6.44% ⬆️ n/a

Annotations

Check warning on line 192 in src/main/java/com/codicesoftware/plugins/jenkins/mergebot/MergebotScm.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered line

Line 192 is not covered by tests

Check warning on line 85 in src/main/java/com/codicesoftware/plugins/jenkins/mergebot/MergebotScmFile.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 52-85 are not covered by tests

Check warning on line 113 in src/main/java/com/codicesoftware/plugins/hudson/model/ChangeSet.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 79-113 are not covered by tests

Check warning on line 730 in src/main/java/com/codicesoftware/plugins/hudson/PlasticSCM.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 159-730 are not covered by tests

Check warning on line 60 in src/main/java/com/codicesoftware/plugins/hudson/ClientConfigurationArguments.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 50-60 are not covered by tests

Check warning on line 56 in src/main/java/com/codicesoftware/plugins/hudson/ChangeSetWriter.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered line

Line 56 is not covered by tests

Check warning on line 44 in src/main/java/com/codicesoftware/plugins/hudson/util/BuildVariableResolver.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 34-44 are not covered by tests

Check warning on line 51 in src/main/java/com/codicesoftware/plugins/hudson/util/MaskedArgumentListBuilder.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 19-51 are not covered by tests

Check warning on line 142 in src/main/java/com/codicesoftware/plugins/hudson/util/FormChecker.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 40-142 are not covered by tests

Check warning on line 36 in src/main/java/com/codicesoftware/plugins/hudson/util/FormFiller.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 22-36 are not covered by tests

Check warning on line 17 in src/main/java/com/codicesoftware/plugins/jenkins/BuildNode.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered line

Line 17 is not covered by tests

Check warning on line 33 in src/main/java/com/codicesoftware/plugins/jenkins/CredentialsFinder.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 30-33 are not covered by tests

Check warning on line 186 in src/main/java/com/codicesoftware/plugins/jenkins/PlasticSCMFile.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 140-186 are not covered by tests

Check warning on line 45 in src/main/java/com/codicesoftware/plugins/jenkins/tools/CmToolInstaller.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 34-45 are not covered by tests

Check warning on line 87 in src/main/java/com/codicesoftware/plugins/jenkins/tools/CmTool.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered line

Line 87 is not covered by tests

Check warning on line 125 in src/main/java/com/codicesoftware/plugins/jenkins/tools/CmTool.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered lines

Lines 105-125 are not covered by tests

Check warning on line 132 in src/main/java/com/codicesoftware/plugins/jenkins/tools/CmTool.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered line

Line 132 is not covered by tests

Check warning on line 97 in src/main/java/com/codicesoftware/plugins/jenkins/tools/CmTool.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Partially covered line

Line 97 is only partially covered, one branch is missing

Check warning on line 131 in src/main/java/com/codicesoftware/plugins/jenkins/tools/CmTool.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Partially covered line

Line 131 is only partially covered, one branch is missing

Check warning on line 137 in src/main/java/com/codicesoftware/plugins/jenkins/tools/CmTool.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Partially covered line

Line 137 is only partially covered, one branch is missing

Check warning on line 31 in src/main/java/com/codicesoftware/plugins/hudson/commands/GetSelectorSpecCommand.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Code Coverage

Not covered line

Line 31 is not covered by tests