Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-lang-feature added: first french lang is added #412

Closed
wants to merge 7 commits into from
Closed

multi-lang-feature added: first french lang is added #412

wants to merge 7 commits into from

Conversation

Dev-Code24
Copy link
Contributor

@Dev-Code24 Dev-Code24 commented Jan 8, 2023 •
edited
Loading

Issue Reference: #408
Changes made in the handbook files

  • I have updated the "write-transitions" script in the package.json file by changing it from "docusaurus-write-translations" to "docusaurus write-translations" as the earlier one was outdated I believe
  • I have added the script “serve” in the package.json file. The script is | “serve”: “docusaurus serve” |
  • I have used the '@docusaurus/Translate' module from the docusaurus modules
  • I have added the i18n folder in the root folder to add the multilingual feature.
Screen.Recording.2023-01-08.at.18.50.06.mov

@Dev-Code24 Dev-Code24 changed the title multi-lang-feature added: first french lang is added multi-lang-feature added: first french lang is added && Docusaurus version updated from 2.1.0 to 2.2.0 Jan 8, 2023
@Dev-Code24
Copy link
Contributor Author

@saghul
Please can you check the PR

saghul
saghul requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, please take a look!

docusaurus.config.js Outdated
@@ -9,7 +9,7 @@ module.exports = {
organizationName: "jitsi",
projectName: "handbook",
favicon: "img/favicon.png",
onBrokenLinks: "throw",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't change this

Copy link
Contributor Author

@Dev-Code24 Dev-Code24 Jan 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul
My purpose in changing this keyword was, to not get errors that block the code when running it. So I changed "throw" to "log" so that all the errors are logged only.

Copy link
Contributor Author

@Dev-Code24 Dev-Code24 Jan 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul
I have edited and made the code back to original for the config file

i18n/fr/code.json
@@ -0,0 +1,432 @@
{"Get started!": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this file used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is used to change the text/Strings in the index.js file inside the src folder from English to French

Copy link
Contributor Author

@Dev-Code24 Dev-Code24 Jan 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was made by the docusaurus i18n translation API

i18n/fr/docusaurus-plugin-content-docs/current/community/breakout-rooms.md
@@ -0,0 +1,18 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this here? Also, it's in English still.

Copy link
Contributor Author

@Dev-Code24 Dev-Code24 Jan 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we need it here.
I guess I didn't change this file's language. I will change this file to French and then push it.

i18n/fr/docusaurus-plugin-content-docs/current.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Dev-Code24
Copy link
Contributor Author

Dev-Code24 commented Jan 14, 2023 •
edited
Loading

@saghul
I have made all the changes that you requested.
i will change the files in this repo for just the multi-language feature and after this PR gets merged I will create a PR for the upgradation of docusaurus version

@Dev-Code24 Dev-Code24 changed the title multi-lang-feature added: first french lang is added && Docusaurus version updated from 2.1.0 to 2.2.0 multi-lang-feature added: first french lang is added Jan 14, 2023
@Dev-Code24 Dev-Code24 requested a review from saghul January 14, 2023 12:27
@saghul
Copy link
Member

saghul commented Jan 15, 2023

Just FYI, some people in the team have reservations about adding this since it's not clear how it can be maintained going forward.

We are going to have a discussion about this soon.

@Dev-Code24
Copy link
Contributor Author

Dev-Code24 commented Jan 15, 2023 •
edited
Loading

Just FYI, some people in the team have reservations about adding this since it's not clear how it can be maintained going forward.

We are going to have a discussion about this soon.

oh...ok! Hopefully, this PR might help the jitsi team members to understand the internationalization process in docusaurus quicker.
How can I proceed with the following PR for the upgradation of the docusaurus version from 2.1.0 to 2.2.0? because I've already changed the files in my local environment and if I do a PR then the translated files will also be pushed in that PR as this PR isn't going to merge.

@saghul
Copy link
Member

saghul commented Jan 15, 2023

Thanks for understanding. Yes the docusaurus update can go in a separate PR no problem!

@Dev-Code24
Copy link
Contributor Author

Dev-Code24 commented Jan 15, 2023 •
edited
Loading

@saghul
I am unable to create a new PR for the update of docusaurus. I have mentioned the problem I am facing in the previous comment.

@Dev-Code24 Dev-Code24 closed this by deleting the head repository Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul Awaiting requested review from saghul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dev-Code24 @saghul