Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Message Handling for jitsi/lib-jitsi-meet/pull/2339 #13745

Closed

Conversation

Bloodiko
Copy link

This is the corresponding xmpp prosody plugin addition in the breakout_rooms plugin for the PR jitsi/lib-jitsi-meet#2339

There may be changes necessary to this, as this lua code is not really complying with the TS Objects types. I was unable to figure out how the objects are correctly typed, so I just gathered as much info as I could from other plugins.
(lua is definitely not my main language, but it was requested in the other PR that this PR should also be created thus, here it is.)

TLDR: Goal is to allow moderators to send single text messages or a whole broadcast text message to all rooms within the same conference.

The "to" argument was chosen to be a composite of source room and occupant/participant nick, to give visual clarity that the message came from a different room.
This can be adjusted if needed.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

saghul
saghul previously approved these changes Sep 8, 2023
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @damencho can you PTAL when you get a chance?

@Bloodiko
Copy link
Author

Bloodiko commented Sep 8, 2023

Wait a second, the Lua check failed with an unterminated String, I'll check and fix later today.
Didn't knew there is a Lua pipeline.

Copy link

github-actions bot commented Dec 9, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 9, 2023
@github-actions github-actions bot closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants