Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feat Breakout Room Messaging/Broadcast message #2339

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Bloodiko
Copy link

This PR adds lib functionality to improve Text Messaging in the following ways:

  • onedirectional "Info"-messaging to all rooms (including main room for backlog reasons?) AKA Broadcast

  • onedirectional "Info"-messaging to a single (Breakout) Room

  • bidirectional "Private Messaging" across all rooms

Keep in mind that broadcasting messages should only be allowed for moderators maybe and only work within the same conference, not across conferences.

Current behaviour:
Message to any room, except the joined room returns an error message from the websocket.
Message to any participant outside the own room returns nothing.

Proposed behaviour:
Message to any room within the boundaries of the conference by a moderator should be allowed, as well as broadcasting a message to all rooms in the conference.
Private messages from any participant to another participant in a different room should be allowed.

Please tell me what you think about this.
I am not experienced enough to create a PR on the backend, so that side will be missing entirely.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

modules/xmpp/ChatRoom.js Outdated Show resolved Hide resolved
modules/xmpp/ChatRoom.js Outdated Show resolved Hide resolved
modules/xmpp/BreakoutRooms.js Show resolved Hide resolved
modules/xmpp/BreakoutRooms.js Show resolved Hide resolved
@Bloodiko Bloodiko marked this pull request as draft August 20, 2023 23:10
@Bloodiko Bloodiko force-pushed the feat/breakoutRoomBroadcast branch from ab5dae5 to c2416a0 Compare August 24, 2023 18:41
Bloodiko added a commit to Bloodiko/jitsi-meet that referenced this pull request Aug 24, 2023
@Bloodiko Bloodiko marked this pull request as ready for review August 24, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants