Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests performance #234

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Improve tests performance #234

merged 2 commits into from
Oct 1, 2021

Conversation

HedicGuibert
Copy link
Member

Tests are currently really slow due to password hashing and database resets, this will speed them up a bit.

@HedicGuibert HedicGuibert added the RFR Ready for review label Sep 29, 2021
@HedicGuibert HedicGuibert force-pushed the test_speed branch 2 times, most recently from cc2b417 to 5d45790 Compare September 30, 2021 16:28
@HedicGuibert HedicGuibert added in progress 🚧 and removed RFR Ready for review labels Sep 30, 2021
@HedicGuibert
Copy link
Member Author

Looks good to me, but we will need to remove the encoder keys when we merge #237.

This is quite faster now !

Before :
before

Now :
after

@HedicGuibert HedicGuibert added RFR Ready for review and removed in progress 🚧 labels Sep 30, 2021
@HedicGuibert HedicGuibert changed the title Remove password hashing for tests Improve tests performance Sep 30, 2021
@HedicGuibert HedicGuibert added in progress 🚧 and removed RFR Ready for review labels Oct 1, 2021
@HedicGuibert HedicGuibert added RFR Ready for review and removed in progress 🚧 labels Oct 1, 2021
@lyrixx lyrixx enabled auto-merge October 1, 2021 09:23
@HedicGuibert
Copy link
Member Author

I rewrote a good part of this PR since I had forgotten some resetDatabase in several places, improving performances further.

Note to my future self and anyone reading this : never use the resetDatabase trait :)

@lyrixx lyrixx merged commit 1ce7c3b into master Oct 1, 2021
@lyrixx lyrixx deleted the test_speed branch October 1, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants