Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nodejs 'global'. #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

obuchtala
Copy link

Some libraries (e.g., lodash) make use of node's 'global' variable (https://nodejs.org/docs/latest/api/all.html#all_global).

@amercier
Copy link

amercier commented Aug 2, 2015

👍

@ctapobep
Copy link

ctapobep commented Aug 5, 2015

Will that be merged? Jasmine for instance uses global so I assume I'd need to downgrade it to have it working until this PR is merged.

@pkozlowski-opensource
Copy link
Member

Will that be merged?

Sure, this looks like a solid change, but we need test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants