Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in Knative Verify #5727

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix deprecation warning in Knative Verify #5727

merged 1 commit into from
Oct 23, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Oct 22, 2023

As per title, this patch fixes the deprecation warning.

As following docs mentions, this patch just changes:

  • python/name:materialx.emoji.twemoji to material.extensions.emoji.twemoji.
  • python/name:materialx.emoji.to_svg to python/name:material.extensions.emoji.to_svg.

https://pypi.org/project/mkdocs-material-extensions/

NOTE: This project is now deprecated as MkDocs for Material now implements this logic directly. Users should migrate to using mkdocs-material's material.extensions.emoji.twemoji and material.extensions.emoji.to_svg in place of the respective materialx.emoji.twemoji and materialx.emoji.to_svg functions provided by this library.

@netlify
Copy link

netlify bot commented Oct 22, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1e31ee6
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/653514e9dbcf3a000716af9a
😎 Deploy Preview https://deploy-preview-5727--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot requested review from nainaz and snneji October 22, 2023 12:26
@knative-prow
Copy link

knative-prow bot commented Oct 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 22, 2023
@nak3
Copy link
Contributor Author

nak3 commented Oct 22, 2023

/cc @Cali0707 @mmejia02 @vinfinity7

@knative-prow knative-prow bot requested review from Cali0707 and mmejia02 October 22, 2023 12:29
@knative-prow
Copy link

knative-prow bot commented Oct 22, 2023

@nak3: GitHub didn't allow me to request PR reviews from the following users: vinfinity7.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Cali0707 @mmejia02 @vinfinity7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3 nak3 mentioned this pull request Oct 22, 2023
@pmbanugo
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@knative-prow knative-prow bot merged commit 7aed08d into knative:main Oct 23, 2023
16 checks passed
pmbanugo added a commit to pmbanugo/knative-docs that referenced this pull request Oct 23, 2023
@pmbanugo
Copy link
Member

@nak3 This is already merged but i think it broke the rendering of the home page

@nak3
Copy link
Contributor Author

nak3 commented Oct 23, 2023

Ugh... Thank you. I will revert this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants