Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename knative-at-kubecon-na-2024.md to knative-at-kubecon-na-2023.md #5734

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

nainaz
Copy link
Contributor

@nainaz nainaz commented Oct 24, 2023

Changing the file name to represent correct year :)

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for knative ready!

Name Link
🔨 Latest commit 163fc50
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6537f6fe84aac70008c68048
😎 Deploy Preview https://deploy-preview-5734--knative.netlify.app/blog/events/knative-at-kubecon-na-2023
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@knative-prow knative-prow bot requested review from skonto and snneji October 24, 2023 16:50
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2023
Adding suggestions from Lance and updating the date
@nainaz nainaz requested review from salaboy and csantanapr and removed request for skonto and snneji October 24, 2023 16:56
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nainaz, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Member

override "Knative Verify / Verify mkdocs strict"

@knative-prow knative-prow bot merged commit 787c193 into main Oct 25, 2023
15 of 16 checks passed
@dprotaso dprotaso deleted the nainaz-patch-2 branch July 30, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants