Adding support for func subscribe for creating mutiple triggers, based on event filters
#2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matzew: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow
bot
added
the
do-not-merge/work-in-progress
knative-prow
bot
added
the
size/L
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2001 +/- ##
==========================================
+ Coverage 63.62% 64.47% +0.85%
==========================================
Files 107 108 +1
Lines 13705 13839 +134
==========================================
+ Hits 8720 8923 +203
+ Misses 4129 4026 -103
- Partials 856 890 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
lkingland
reviewed
Oct 3, 2023
matzew
force-pushed
the
add_func_subscribe
branch
from
479723f to
365bb02
Compare
matzew
changed the title
func subscribe for creating mutiple triggers, ba…func subscribe for creating mutiple triggers, based on event filters
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
/hold the filtering needs to be a bit different |
knative-prow
bot
added
the
do-not-merge/hold
|
Hi @matzew . If possible, could you add some test pls? |
matzew
force-pushed
the
add_func_subscribe
branch
from
555d90e to
1b85459
Compare
We do install Eventing in our test cluster, so an integration test in https://github.com/knative/func/blob/main/pkg/functions/client_int_test.go might be fairly straightforward |
matzew
force-pushed
the
add_func_subscribe
branch
2 times, most recently
from
5280d74 to
cbbac15
Compare
matzew
force-pushed
the
add_func_subscribe
branch
5 times, most recently
from
a3f81a7 to
0855979
Compare
matzew
force-pushed
the
add_func_subscribe
branch
from
0855979 to
1f685de
Compare
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
…sed on event filters Signed-off-by: Matthias Wessendorf <[email protected]>
Co-authored-by: Luke Kingland <[email protected]>
Co-authored-by: Luke Kingland <[email protected]>
Co-authored-by: Luke Kingland <[email protected]>
Co-authored-by: Luke Kingland <[email protected]>
Co-authored-by: Luke Kingland <[email protected]>
Co-authored-by: Luke Kingland <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
matzew
force-pushed
the
add_func_subscribe
branch
from
a4b5e99 to
810a003
Compare
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
matzew
force-pushed
the
add_func_subscribe
branch
from
5774349 to
c30a5c4
Compare
lkingland
approved these changes
Nov 6, 2023
| @@ -76,6 +76,7 @@ Learn more about Knative at: https://knative.dev`, cfg.Name), | |||
| NewDeployCmd(newClient), | |||
| NewDeleteCmd(newClient), | |||
| NewListCmd(newClient), | |||
| NewSubscribeCmd(), | |||
There was a problem hiding this comment.
For testing support, this should pass through the newClient client factory; but I don't think that should hold up the PR.
There was a problem hiding this comment.
I will add additional PR. thanks for the review on this
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
matzew
added a commit
to matzew/kn-plugin-func
that referenced
this pull request
Nov 7, 2023
…sed on event filters (knative#2001) * Adding support for `func subscribe` for creating mutiple triggers, based on event filters Signed-off-by: Matthias Wessendorf <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * removing unused import Signed-off-by: Matthias Wessendorf <[email protected]> * running make Signed-off-by: Matthias Wessendorf <[email protected]> * Some import ogranization Signed-off-by: Matthias Wessendorf <[email protected]> * Change argument syntax Signed-off-by: Matthias Wessendorf <[email protected]> * changes Signed-off-by: Matthias Wessendorf <[email protected]> * Adding some emoji text Signed-off-by: Matthias Wessendorf <[email protected]> * 💄 move subscriptions underneath the deploy element Signed-off-by: Matthias Wessendorf <[email protected]> * adding silly emoji to build Signed-off-by: Matthias Wessendorf <[email protected]> * Adding some simple/copied/modified test Signed-off-by: Matthias Wessendorf <[email protected]> * Running 'make schema-generate' Signed-off-by: Matthias Wessendorf <[email protected]> * Update function Signed-off-by: Matthias Wessendorf <[email protected]> * Little unit test Signed-off-by: Matthias Wessendorf <[email protected]> * Adding a bit more help text Signed-off-by: Matthias Wessendorf <[email protected]> * misspell instruction Signed-off-by: Matthias Wessendorf <[email protected]> --------- Signed-off-by: Matthias Wessendorf <[email protected]> Co-authored-by: Luke Kingland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little demo: https://youtu.be/O6M7mfR6JfM
Changes
subscribecommand to create Knative Triggers for event routing/kind
Fixes #
Release Note
Docs