Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofreading improvements #355

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Proofreading improvements #355

merged 9 commits into from
Oct 21, 2024

Conversation

lorenzocerrone
Copy link
Collaborator

@lorenzocerrone lorenzocerrone commented Oct 20, 2024

  • General cleanup of proofreading code. Remove redundant copying of the data in the proofreading handler.
  • Add methods to save and construct a plantseg image from h5.
  • Save proofreading state to disk as h5
  • Proofreading seems to work now on all orientations (to be tested more extensively)

Unrelated changes:

@qin-yu test it a bit and let me know if the behavior did not change

@lorenzocerrone lorenzocerrone requested a review from qin-yu October 20, 2024 15:23
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 29.18919% with 262 lines in your changes missing coverage. Please review.

Project coverage is 64.81%. Comparing base (d19176e) to head (f8bfe4b).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
plantseg/viewer_napari/widgets/proofreading.py 27.62% 186 Missing ⚠️
plantseg/core/image.py 34.09% 29 Missing ⚠️
plantseg/tasks/dataprocessing_tasks.py 17.64% 14 Missing ⚠️
plantseg/viewer_napari/widgets/io.py 38.09% 13 Missing ⚠️
plantseg/viewer_napari/widgets/prediction.py 33.33% 12 Missing ⚠️
plantseg/viewer_napari/widgets/dataprocessing.py 14.28% 6 Missing ⚠️
plantseg/viewer_napari/widgets/segmentation.py 0.00% 1 Missing ⚠️
plantseg/viewer_napari/widgets/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
- Coverage   66.33%   64.81%   -1.52%     
==========================================
  Files          70       70              
  Lines        4987     5159     +172     
==========================================
+ Hits         3308     3344      +36     
- Misses       1679     1815     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lorenzocerrone lorenzocerrone merged commit fd7ff08 into master Oct 21, 2024
2 checks passed
@lorenzocerrone lorenzocerrone deleted the proofreading_improvements branch October 21, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Areas of GUI improvement after v2.0.0a4
1 participant