Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow more runtime errors in find_batch_size() #359

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

qin-yu
Copy link
Collaborator

@qin-yu qin-yu commented Nov 18, 2024

This PR attempts to fix #358.

  1. find_batch_size() now catches and handles all runtime errors during probing.
  2. A specific issue, where VRAM is sufficient but the layer can only support INT_MAX elements, is tested.

@qin-yu qin-yu added the bug Something isn't working label Nov 18, 2024
@qin-yu qin-yu self-assigned this Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.89%. Comparing base (36e9445) to head (4fcd3f7).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...antseg/functionals/prediction/utils/size_finder.py 0.00% 4 Missing ⚠️
tests/functionals/prediction/test_size_finder.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   64.94%   64.89%   -0.05%     
==========================================
  Files          71       71              
  Lines        5177     5187      +10     
==========================================
+ Hits         3362     3366       +4     
- Misses       1815     1821       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@qin-yu qin-yu merged commit db2bea1 into master Nov 19, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-OOM error can happen during find_batch_size()
1 participant