fix: allow but warn all runtime errors in 3D find_a_max_patch_shape()
#361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it's the problem from PlantSeg because nothing has been changed for the bioimage.io part: =========================== short test summary info ============================
FAILED tests/core/test_zoo.py::TestBioImageIOModelZoo::test_get_model_by_id[efficient-chipmunk] - ValueError: Failed to load efficient-chipmunk
FAILED tests/core/test_zoo.py::TestBioImageIOModelZoo::test_get_model_by_id[pioneering-rhino] - ValueError: Failed to load pioneering-rhino
FAILED tests/core/test_zoo.py::TestBioImageIOModelZoo::test_halo_computation_for_bioimageio_model[efficient-chipmunk] - ValueError: Failed to load efficient-chipmunk
FAILED tests/core/test_zoo.py::TestBioImageIOModelZoo::test_halo_computation_for_bioimageio_model[pioneering-rhino] - ValueError: Failed to load pioneering-rhino
======= 4 failed, 126 passed, 11 skipped, 3 warnings in 65.19s (0:01:05) =======I'll merge it with the failed tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I only updated the
try ... catch ...for 3D. The 2D case won't be limited by the layerINT_MAXconstraint because the largest patch is1 x 3200 x 3200which is also tested now.Tests are updated too.