Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkpoint loading across months #93

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix checkpoint loading across months #93

wants to merge 6 commits into from

Conversation

WT-MM
Copy link
Member

@WT-MM WT-MM commented Oct 2, 2024

No description provided.

@WT-MM WT-MM requested a review from budzianowski October 2, 2024 00:19
budzianowski
budzianowski reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@budzianowski budzianowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about years? :)

@WT-MM
Copy link
Member Author

WT-MM commented Oct 2, 2024

I can get on that when 2025 rolls around

@budzianowski budzianowski self-requested a review October 2, 2024 17:33
budzianowski
budzianowski requested changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@budzianowski budzianowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the test and make it work with days months and years.

@budzianowski budzianowski self-requested a review October 3, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budzianowski budzianowski Awaiting requested review from budzianowski

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WT-MM @budzianowski