feat: add metallic material rendering to URDF robot #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Added updateMaterials function to set metallic properties - Enhanced lighting setup for better metallic visualization - Preserved original colors while adding metallic effect - Set metalness to 0.4 and roughness to 0.5 Co-Authored-By: Benjamin Bolte <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
codekansas
requested changes
Dec 11, 2024
|
|
||
| // Correcting for the robot initial size and position. |
There was a problem hiding this comment.
don't need to delete this comment
| @@ -89,7 +105,6 @@ const RobotRenderer: React.FC = () => { | |||
| requestAnimationFrame(animate); | |||
| controls.update(); | |||
|
|
|||
| // Update joint positions with a sinusoidal pattern | |||
Comment on lines
-112
to
+136
| const light = new THREE.AmbientLight(0x404040); | ||
| scene.add(light); | ||
| const ambientLight = new THREE.AmbientLight(0xffffff, 0.3); | ||
| scene.add(ambientLight); | ||
|
|
||
| const mainLight = new THREE.DirectionalLight(0xffffff, 2.0); | ||
| mainLight.position.set(5, 5, 5); | ||
| scene.add(mainLight); | ||
|
|
||
| const directionalLight = new THREE.DirectionalLight(0xffffff, 0.5); | ||
| directionalLight.position.set(1, 1, 1).normalize(); | ||
| scene.add(directionalLight); | ||
| const fillLight = new THREE.DirectionalLight(0xffffff, 0.8); | ||
| fillLight.position.set(-5, 2, -5); | ||
| scene.add(fillLight); |
There was a problem hiding this comment.
this seems unrelated to the pr but is a good change. can we make this into a separare pr, with a screenshot of how it looks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metallic material rendering to URDF robot
This PR updates the URDF renderer to display metallic materials, matching the implementation from web-dashboard.
Changes:
Testing:
Reference implementation: web-dashboard/src/components/files/URDFRenderer.tsx
Link to Devin run: https://app.devin.ai/sessions/a4ebae7099e541cc85d5601727cf5bcb