Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typos checkerを導入し軽微なtypoを修正 #5233

Merged
merged 10 commits into from
Dec 26, 2024

Conversation

Qs-F
Copy link
Contributor

@Qs-F Qs-F commented Dec 25, 2024

関連URL

typoを検出するためtyposを導入

概要

typosという高速typo検出CIを導入

一旦すぐに対応できず除外したいワードは .typos.toml に追加していってください!

参考:

smarthr-ui/.typos.toml

Lines 7 to 10 in 2e8db7e

[default.extend-words]
# https://github.com/kufu/smarthr-ui/pull/5230 で修正予定
BACKGROUNDS = 'BACKGROUNDS'
BACKGRUOND = 'BACKGRUOND'

変更内容

  • typosを導入

確認方法

Copy link

pkg-pr-new bot commented Dec 25, 2024

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5233

commit: 5be61f4

@Qs-F Qs-F marked this pull request as ready for review December 26, 2024 02:03
@Qs-F Qs-F requested a review from a team as a code owner December 26, 2024 02:03
@Qs-F Qs-F requested review from AtsushiM and hiroki0525 and removed request for a team December 26, 2024 02:03
@Qs-F Qs-F changed the title chore: typo checkerを導入 chore: typo checkerを導入し軽微なタイポを修正 Dec 26, 2024
@Qs-F Qs-F changed the title chore: typo checkerを導入し軽微なタイポを修正 chore: typos checkerを導入し軽微なタイポを修正 Dec 26, 2024
@Qs-F Qs-F changed the title chore: typos checkerを導入し軽微なタイポを修正 chore: typos checkerを導入し軽微なtypoを修正 Dec 26, 2024
Copy link
Collaborator

@uknmr uknmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

'hover:shr-border-darken',
'hover:shr-bg-white-darken',
'hover:constrast-more:shr-border-high-contrast',
'hover:contrast-more:shr-border-high-contrast',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よく読んでないですが、ここ挙動に変更生じます?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VRTが反応しなかったんでいいかな〜としちゃったんですが一応見てきます!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見てきたんですが特に変更がある様子がなかったですね 🤔

Copy link
Contributor

@s-sasaki-0529 s-sasaki-0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍️ contrast-more の変更も、まぁ少なくとも派手に壊れることは無さそうなので Approve

@Qs-F Qs-F merged commit a5b3b1f into master Dec 26, 2024
24 checks passed
@Qs-F Qs-F deleted the chore/introduce-typo-checker branch December 26, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants