Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typos checkerを導入し軽微なtypoを修正 #5233

Merged
merged 10 commits into from
Dec 26, 2024
Merged

chore: typos checkerを導入し軽微なtypoを修正 #5233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a4c40b5
chore: typo checkerを導入
Qs-F Dec 25, 2024
874e04f
fix: ignore CHANGELOG file
Qs-F Dec 25, 2024
d13f222
fix: config
Qs-F Dec 26, 2024
2d3a568
fix: config
Qs-F Dec 26, 2024
ca2a5c5
fix: config
Qs-F Dec 26, 2024
b2cddd5
fix: config
Qs-F Dec 26, 2024
2f44300
docs: add comment
Qs-F Dec 26, 2024
2e8db7e
fix: typos
Qs-F Dec 26, 2024
094c50b
Merge remote-tracking branch 'origin' into chore/introduce-typo-checker
Qs-F Dec 26, 2024
5be61f4
fix: remove words since it is fixed
Qs-F Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/typoChecker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Typo Checker
on: [pull_request]

jobs:
run:
name: Typo Checker
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use custom config file
uses: crate-ci/typos@master
with:
config: ./.typos.toml
7 changes: 7 additions & 0 deletions .typos.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[files]
extend-exclude = [
'CHANGELOG.md',
'smarthr-ui-props.json',
]

[default.extend-words]
12 changes: 6 additions & 6 deletions packages/smarthr-ui/src/components/AppHeader/stories/VRTAppHeader.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const VRTNameOnly: Story = {
empCode: null,
firstName: '須磨',
lastName: '栄子',
accountUrl: 'https://exmaple.com',
accountUrl: 'https://example.com',
},
},
}
Expand All @@ -44,7 +44,7 @@ export const VRTEmpCodeOnly: Story = {
empCode: '001',
firstName: null,
lastName: null,
accountUrl: 'https://exmaple.com',
accountUrl: 'https://example.com',
},
},
}
Expand All @@ -56,7 +56,7 @@ export const VRTEmailOnly: Story = {
empCode: null,
firstName: null,
lastName: null,
accountUrl: 'https://exmaple.com',
accountUrl: 'https://example.com',
},
},
}
Expand All @@ -68,7 +68,7 @@ export const VRTNoUserInfo: Story = {
empCode: null,
firstName: null,
lastName: null,
accountUrl: 'https://exmaple.com',
accountUrl: 'https://example.com',
},
},
}
Expand Down Expand Up @@ -116,7 +116,7 @@ export const VRTReleaseNoteLoading: Story = {
releaseNote: {
loading: true,
links: [],
indexUrl: 'https://exmaple.com',
indexUrl: 'https://example.com',
},
},
play: async ({ canvasElement }) => {
Expand All @@ -130,7 +130,7 @@ export const VRTReleaseNoteError: Story = {
releaseNote: {
error: true,
links: [],
indexUrl: 'https://exmaple.com',
indexUrl: 'https://example.com',
},
},
play: async ({ canvasElement }) => {
Expand Down
30 changes: 15 additions & 15 deletions packages/smarthr-ui/src/components/AppHeader/stories/args.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ export const args: ComponentProps<typeof AppHeader> = {
],
currentTenantId: 'tenant-1',
onTenantSelect: action('テナント選択'),
schoolUrl: 'https://exmaple.com',
helpPageUrl: 'https://exmaple.com',
schoolUrl: 'https://example.com',
helpPageUrl: 'https://example.com',
locale: {
selectedLocale: 'ja',
onSelectLocale: action('locale'),
Expand All @@ -47,18 +47,18 @@ export const args: ComponentProps<typeof AppHeader> = {
empCode: '001',
firstName: '須磨',
lastName: '栄子',
accountUrl: 'https://exmaple.com',
accountUrl: 'https://example.com',
},
desktopAdditionalContent: <AdditionalContent>desktopAdditionalContent</AdditionalContent>,
navigations: [
{
children: 'aタグ',
href: 'https://exmaple.com',
href: 'https://example.com',
},
{
children: 'カスタムタグ',
elementAs: CustomLink,
to: 'https://exmaple.com',
to: 'https://example.com',
},
{
children: 'ボタン',
Expand All @@ -69,12 +69,12 @@ export const args: ComponentProps<typeof AppHeader> = {
childNavigations: [
{
children: 'aタグ',
href: 'https://exmaple.com',
href: 'https://example.com',
},
{
children: 'カスタムタグ',
elementAs: CustomLink,
to: 'https://exmaple.com',
to: 'https://example.com',
},
{
children: 'ボタン',
Expand All @@ -90,12 +90,12 @@ export const args: ComponentProps<typeof AppHeader> = {
childNavigations: [
{
children: 'グループ1_アイテム1',
href: 'https://exmaple.com',
href: 'https://example.com',
current: true,
},
{
children: 'グループ1_アイテム2',
href: 'https://exmaple.com',
href: 'https://example.com',
},
],
},
Expand All @@ -104,11 +104,11 @@ export const args: ComponentProps<typeof AppHeader> = {
childNavigations: [
{
children: 'グループ2_アイテム1',
href: 'https://exmaple.com',
href: 'https://example.com',
},
{
children: 'グループ2_アイテム2',
href: 'https://exmaple.com',
href: 'https://example.com',
},
],
},
Expand All @@ -122,18 +122,18 @@ export const args: ComponentProps<typeof AppHeader> = {
links: [
{
title: 'リリースノート1',
url: 'https://exmaple.com',
url: 'https://example.com',
},
{
title: 'リリースノート2',
url: 'https://exmaple.com',
url: 'https://example.com',
},
{
title: 'リリースノート3',
url: 'https://exmaple.com',
url: 'https://example.com',
},
],
indexUrl: 'https://exmaple.com',
indexUrl: 'https://example.com',
},
features: [
buildFeature(1, '従業員リスト', false),
Expand Down
8 changes: 4 additions & 4 deletions packages/smarthr-ui/src/components/AppNavi/stories/AppNaviAnchor.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { AppNaviAnchor } from '../AppNaviAnchor'

import type { Meta, StoryObj } from '@storybook/react'

const _iconOptoins = {
const _iconOptions = {
なし: undefined,
あり: FaGearIcon,
}
Expand All @@ -28,8 +28,8 @@ export default {
argTypes: {
icon: {
control: 'radio',
options: Object.keys(_iconOptoins),
mapping: _iconOptoins,
options: Object.keys(_iconOptions),
mapping: _iconOptions,
},
elementAs: {
control: 'radio',
Expand Down Expand Up @@ -64,7 +64,7 @@ export const Href: StoryObj<typeof AppNaviAnchor> = {
export const Icon: StoryObj<typeof AppNaviAnchor> = {
name: 'icon',
args: {
icon: _iconOptoins['あり'],
icon: _iconOptions['あり'],
},
}

Expand Down
8 changes: 4 additions & 4 deletions packages/smarthr-ui/src/components/AppNavi/stories/AppNaviButton.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { AppNaviButton } from '../AppNaviButton'

import type { Meta, StoryObj } from '@storybook/react'

const _iconOptoins = {
const _iconOptions = {
なし: undefined,
あり: FaGearIcon,
}
Expand All @@ -19,8 +19,8 @@ export default {
argTypes: {
icon: {
control: 'radio',
options: Object.keys(_iconOptoins),
mapping: _iconOptoins,
options: Object.keys(_iconOptions),
mapping: _iconOptions,
},
},
args: {
Expand All @@ -40,7 +40,7 @@ export const Playground: StoryObj<typeof AppNaviButton> = {}
export const Icon: StoryObj<typeof AppNaviButton> = {
name: 'icon',
args: {
icon: _iconOptoins['あり'],
icon: _iconOptions['あり'],
},
}

Expand Down
8 changes: 4 additions & 4 deletions packages/smarthr-ui/src/components/AppNavi/stories/AppNaviCustomTag.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { AppNaviCustomTag } from '../AppNaviCustomTag'

import type { Meta, StoryObj } from '@storybook/react'

const _iconOptoins = {
const _iconOptions = {
なし: undefined,
あり: FaGearIcon,
}
Expand All @@ -29,8 +29,8 @@ export default {
argTypes: {
icon: {
control: 'radio',
options: Object.keys(_iconOptoins),
mapping: _iconOptoins,
options: Object.keys(_iconOptions),
mapping: _iconOptions,
},
},
args: {
Expand All @@ -51,7 +51,7 @@ export const Playground: StoryObj<typeof AppNaviCustomTag> = {}
export const Icon: StoryObj<typeof AppNaviCustomTag> = {
name: 'icon',
args: {
icon: _iconOptoins['あり'],
icon: _iconOptions['あり'],
},
}

Expand Down
4 changes: 2 additions & 2 deletions packages/smarthr-ui/src/components/Button/ButtonWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,10 @@ const button = tv({
'shr-text-black',
'focus-visible:shr-border-darken',
'focus-visible:shr-bg-white-darken',
'focus-visible:constrast-more:shr-border-high-contrast',
'focus-visible:contrast-more:shr-border-high-contrast',
'hover:shr-border-darken',
'hover:shr-bg-white-darken',
'hover:constrast-more:shr-border-high-contrast',
'hover:contrast-more:shr-border-high-contrast',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よく読んでないですが、ここ挙動に変更生じます？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VRTが反応しなかったんでいいかな〜としちゃったんですが一応見てきます！

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見てきたんですが特に変更がある様子がなかったですね 🤔

],
},
{
Expand Down
4 changes: 2 additions & 2 deletions packages/smarthr-ui/src/components/InformationPanel/stories/VRTInformationPanel.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ import type { Meta } from '@storybook/react'
* $ pict information-panel.pict
* type bold togglable active
* success false true true
* infor false false false
* info false false false
* error true false true
* sync false false false
* sync false true false
* success true false false
* warning true true true
* infor false true true
* info false true true
* error false true false
* warning false false false
* sync false false true
Expand Down
4 changes: 2 additions & 2 deletions packages/smarthr-ui/src/components/InformationPanel/stories/information-panel.pict
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
type: success, infor, warning, error, sync
type: success, info, warning, error, sync
bold: false, true
togglable: false (10), true
active: false, true (10)

IF [bold] = "true" THEN [type] IN {"success", "warning", "error"};
IF [bold] = "true" THEN [type] IN {"success", "warning", "error"};
2 changes: 1 addition & 1 deletion packages/smarthr-ui/src/components/TabBar/stories/VRTTabBar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import type { Meta, StoryObj } from '@storybook/react'
export default {
title: 'Navigation（ナビゲーション）/TabBar/VRT',
/* ペアワイズ法による網羅
* bordered selected diasbled suffix disabledDetail
* bordered selected disabled suffix disabledDetail
* false false false あり なし
* false true true なし あり
* true true true あり なし
Expand Down
2 changes: 1 addition & 1 deletion packages/smarthr-ui/src/themes/__tests__/createFontSize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('createFontSize', () => {
expect(actual.XXL).toBe(`${8 / 5}rem`)
})

it('the value from scaleFactor wil be overridden if a deprecated abstract value is specified', () => {
it('the value from scaleFactor will be overridden if a deprecated abstract value is specified', () => {
const actual = createFontSize({
scaleFactor: 8,
S: '1.1rem',
Expand Down
Loading