Add tests for bml_add_norm
#533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasbock
requested review from
cnegre,
jeanlucf22,
jmohdyusof,
suemni and
tokshgithub
as code owners
nicolasbock
commented
Jul 15, 2021
| } | ||
| expected_trace_norm = sqrt(expected_trace_norm); |
There was a problem hiding this comment.
@cnegre The ellsort implementation returns the square of the norm. What is the expected output; the norm or the square of the norm?
cnegre
approved these changes
Jul 15, 2021
suemni
approved these changes
Jul 15, 2021
|
This PR is stale because it has been open for 90 days with no activity. |
Closes: lanl#531 Signed-off-by: Nicolas Bock <[email protected]>
nicolasbock
force-pushed
the
issue_531
branch
from
99e5568 to
9b60369
Compare
|
This PR is stale because it has been open for 90 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #531
Signed-off-by: Nicolas Bock [email protected]