Combine librealsense and RSSDK as one single grabber #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o sdks' real_sense_grabber
This reverts commit 2d216a3.
|
Code LGTM. After I merge your PR, the PR to PCL: PointCloudLibrary#1633 should update. Then you can let upstream to start review. Before upstream merge, you can follow either https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit or https://github.com/blog/2141-squash-your-commits to merge them into one. Per upstream's opinion. You can ask them after your code gets LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@huningxin please take a look.
After you merged this PR, should I rebase the master branch as just one commitment "Add librealsense support to RealSenseGrabber" or just open another PR to PCL through another branch like already rebased existing branch 'dev01' and close the previous one?