[Firtool] Move the remaining pass additions into lib

[SpriteOvO]

Context: #6036 (comment)

[mikeurbach]

Thanks for working on this, I think this is a good refactoring to do.

However, see my comments about createHWExportModuleHierarchyPass, I think we need to be careful here to maintain the previous behavior.

[SpriteOvO]

@mikeurbach Thanks for your review ^^, I have updated this PR according to your suggestions.

Dismissed after latest updates.

[mikeurbach]

I think this looks good now. I would like to get some other eyes on it as well. @nandor @youngar I think you two looked at the initial creation of lib/Firtool, any gotchas we're missing here?

[SpriteOvO]

Oh, I forgot to say, in the latest commit, I made the populatePrepareForExportVerilog function private to users by moving it into a detail namespace and calling it inside populateExport{,Split}Verilog, so that users are no longer required to call it manually before export.

[mikeurbach]

Oh, I forgot to say, in the latest commit, I made the populatePrepareForExportVerilog function private to users by moving it into a detail namespace and calling it inside populateExport{,Split}Verilog, so that users are no longer required to call it manually before export.

I like this. It makes sense to me--if you're using the firtool pipeline, when you go to export verilog, some of those preparation transformations are required for correctness.

[sequencer]

Any chance to get this PR in?

[mikeurbach]

Sorry, I thought I had marked approved. I think this is ready to go, except it seems some merge conflicts exist. Someone must have added a new pass :/ All the more reason to get this merged.

[SpriteOvO]

@mikeurbach I have rebased the PR, and will merge it once the CI are all green. Thank you again!