[Calyx] Passing memories by reference #7164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgyurgyik
reviewed
Jun 12, 2024
|
Nice! A few small comments and request for tests. |
jiahanxie353
force-pushed
the
pass-mem-by-ref
branch
from
d581ee4 to
a9c7367
Compare
jiahanxie353
requested review from
mikeurbach,
mortbopet and
andrewb1999
as code owners
jiahanxie353
force-pushed
the
pass-mem-by-ref
branch
2 times, most recently
from
bc067c6 to
5b11808
Compare
jiahanxie353
force-pushed
the
pass-mem-by-ref
branch
from
5b11808 to
9af7966
Compare
cgyurgyik
reviewed
Jul 10, 2024
jiahanxie353
force-pushed
the
pass-mem-by-ref
branch
from
9af7966 to
ad89e27
Compare
…l memoryOp inside the component
…and pass scf to calyx convert memory tests
…tance with both memref and non-memref arguments
…ss memory by reference
…t alloc into the new top-level marking it external and mark the old top-level alloc-memories non-external/reference; reason being the calyx compiler requires external memories only exist in the top-level
because we will erase all `alloc` ops in the original top-level function, and build new `alloc` ops in the new top-level function to pass them through `call`. Also reimplement the logic used for identifying the corresponding reference memory cell in the callee when building `invokeOp`.
…e order of insertion point so that the number of the reference and the external memory align in the invoke
…lyx yxi requires to do so
jiahanxie353
force-pushed
the
pass-mem-by-ref
branch
from
ad89e27 to
1a33416
Compare
cgyurgyik
reviewed
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses #4831 .
If the
mainFuncOphasmemrefs in its arguments, we create a newmaincomponent and make it the new entry point.