Add function to generate unique validation code for gift cards. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalfVoxel
approved these changes
Dec 5, 2023
| from secrets import token_hex | ||
|
|
||
|
|
||
| def generate_gift_card_code(length=16): |
There was a problem hiding this comment.
Length=10 is probably enough (number of alternatives is then about 10^12). But I don't really care that much.
There was a problem hiding this comment.
We'd only get a probable collision after about a million gift cards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When purchasing gift cards, a unique validation code is required that the user will be able to use to redeem said gift card.
This commit/function aims to be able to generate those validation codes.
Please provide feedback if this is safe usage and/or if the length of the validation code needs to be altered. Maybe I need to implement some sort of List() that keeps track of all validation codes to "ensure" that the validation code is indeed unique?