-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to generate unique validation code for gift cards. #379
Merged
BerglundDaniel
merged 5 commits into
makerspace:master
from
Kotik112:add-validation-code-generating-function
Dec 6, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
94063a4
Add function to generate unique validation code for gift cards.
Arman-prevas c9d0d5d
Validation code is returned in upper case.
Arman-prevas 630e08a
Add tests for generate_gift_card_code()
Arman-prevas 5d73164
Fix broken import in gift_card_test.py
Arman-prevas c44e922
Improve message when GiftCardTest(s) fail
Arman-prevas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
from secrets import token_hex | ||
|
||
|
||
def generate_gift_card_code(length=16): | ||
""" | ||
Generate a unique validation code for gift cards. | ||
|
||
Parameters: | ||
- length: The length of the validation code (default is 16). | ||
|
||
Returns: | ||
A unique validation code. | ||
""" | ||
return token_hex(length)[:length].upper() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
from unittest import TestCase | ||
from shop.gift_card_util import generate_gift_card_code | ||
|
||
|
||
class GiftCardTest(TestCase): | ||
def test_generate_validation_code_default_length(self): | ||
validation_code = generate_gift_card_code() | ||
msg = "Test failed: validation code is not 16 characters long." | ||
self.assertEqual(len(validation_code), 16, msg=msg) | ||
|
||
def test_generate_validation_code_custom_length(self): | ||
validation_code = generate_gift_card_code(32) | ||
msg = "Test failed: validation code is not 32 characters long." | ||
self.assertEqual(len(validation_code), 32, msg=msg) | ||
|
||
def test_generate_validation_code_unique(self): | ||
validation_code_1 = generate_gift_card_code() | ||
validation_code_2 = generate_gift_card_code() | ||
msg = "Test failed: validation codes are not unique." | ||
self.assertNotEqual(validation_code_1, validation_code_2, msg=msg) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Length=10 is probably enough (number of alternatives is then about 10^12). But I don't really care that much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd only get a probable collision after about a million gift cards.