-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
identify .NET single file bundles #841
Changes from 3 commits
da035e2
fc0fda2
3089ba8
3396236
c9f2d7d
08b3d5c
8e8a7d9
2227807
7c31b3e
b649129
cbd07c0
56334a4
e15a1f7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sorry, I meant from the changes, not to delete the file :) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
rule: | ||
meta: | ||
name: bundled with .NET single-file deployment | ||
namespace: runtime/dotnet | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should this go into the |
||
authors: | ||
- [email protected] | ||
scope: file | ||
references: | ||
- https://learn.microsoft.com/en-us/dotnet/core/deploying/single-file/overview?tabs=cli | ||
- https://github.com/dotnet/runtime/blob/84de9b678613675e0444b265905c82d33dae33a8/src/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs | ||
examples: | ||
- a83339b07cf2bf1aeda192de42760c625d4b2f106260f58c902d02f4766848d5 | ||
features: | ||
- or: | ||
- and: | ||
- match: contains PDB path | ||
- string: "singlefilehost.pdb" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add a description why this may be a good signal? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure. this is the symbol file for the native executable when publish single file is set to True |
||
description = symbol file for the native executable when publish single file is true | ||
sara-rn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- export: DotNetRuntimeInfo | ||
- export: corehost_initialize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this file from the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, understood, didn't know how to I guess, can you reject this specific commit?