identify .NET single file bundles #841
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| - match: contains PDB path | ||
| - string: "singlefilehost.pdb" |
There was a problem hiding this comment.
can you add a description why this may be a good signal?
There was a problem hiding this comment.
sure. this is the symbol file for the native executable when publish single file is set to True
README.md
Outdated
There was a problem hiding this comment.
please remove this file from the PR
There was a problem hiding this comment.
yep, understood, didn't know how to I guess, can you reject this specific commit?
| name: bundled with .NET single-file deployment | ||
| namespace: runtime/dotnet |
There was a problem hiding this comment.
should this go into the internal\limitation\file directory/namespace to avoid further processing?
Co-authored-by: Moritz <[email protected]>
README.md
Outdated
There was a problem hiding this comment.
sorry, I meant from the changes, not to delete the file :)
|
Cool, can you address the parsing/linter fail and then this should be good to go. |
|
There's also |
|
will create a new PR for this |
.NET single file deployments allow all the dependencies to be included in a single binary. Other capa rules might not be relevant for this single file bundles. Perhaps a warning could be displayed, same as for MSI. Additional information can be found in https://learn.microsoft.com/en-us/dotnet/core/deploying/single-file/overview?tabs=cli