Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify .NET single file bundles #841

Closed
wants to merge 13 commits into from
151 changes: 0 additions & 151 deletions README.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file from the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, understood, didn't know how to I guess, can you reject this specific commit?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I meant from the changes, not to delete the file :)

This file was deleted.

20 changes: 20 additions & 0 deletions bundled-with-dotnet-single-file-deployment.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
rule:
meta:
name: bundled with .NET single-file deployment
namespace: runtime/dotnet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this go into the internal\limitation\file directory/namespace to avoid further processing?

authors:
- [email protected]
scope: file
references:
- https://learn.microsoft.com/en-us/dotnet/core/deploying/single-file/overview?tabs=cli
- https://github.com/dotnet/runtime/blob/84de9b678613675e0444b265905c82d33dae33a8/src/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs
examples:
- a83339b07cf2bf1aeda192de42760c625d4b2f106260f58c902d02f4766848d5
features:
- or:
- and:
- match: contains PDB path
- string: "singlefilehost.pdb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a description why this may be a good signal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. this is the symbol file for the native executable when publish single file is set to True

description = symbol file for the native executable when PublishSingleFile is true
- export: DotNetRuntimeInfo
- export: corehost_initialize
Loading