-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full gimbal angle control #328
Conversation
Can you elaborate a bit? I am not sure I understand what this means... Are you saying that your Gimbal is reading the MAVLink message incorrectly, and therefore you want to invert the values you send from MAVSDK instead of fixing the Gimbal side? |
I see, so you need the roll axis. It was initially not exposed because cameras don't really need to set the roll axis 😇. @julianoes: do you have an opinion on that? |
protos/gimbal/gimbal.proto
Outdated
float pitch_deg = 1; // Pitch angle in degrees (negative points down) | ||
float yaw_deg = 2; // Yaw angle in degrees (positive is clock-wise, range: -180 to 180 or 0 to 360) | ||
float roll_deg = 3; // Roll angle in degrees |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please change the order of the fields to match the usual MAVLink order: roll, pitch, yaw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Shall I do it, or do you do it? As I said, this is my first time. Happy to help where I can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you change it. Thanks!
This feature is a request as I have to use the gimbal I have in a certain way and the roll and pitch axis are switched.
As the pitch of the payload of the gimbal is vitally important, this feature is needed.