Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed long_description info from setup.py #767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kachida
Copy link

@kachida kachida commented Mar 9, 2024

Hi @ksaur , can you please review the below PR#

#766

@@ -44,9 +44,6 @@
setup(
name="hummingbird-ml",
version=version_str,
description="Convert trained traditional machine learning models into tensor computations",
long_description=long_description,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello thanks for your PR! The goal is not to delete this text entirely, but to make it legal with the new-style setup.py files. Something like this:

Screenshot 2024-03-11 at 10 01 18 AM

Copy link
Contributor

@ksaur ksaur Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment in the issue "For now just deleted these 3 lines, but we should change the format away from markdown. See docs" ... Thanks!!

@ksaur ksaur mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants