Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed long_description info from setup.py #767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: removed long_description info from setup.py #767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
assert packages

# read version from the package file.
with (open(os.path.join(this, "hummingbird/__init__.py"), "r")) as f:
with open(os.path.join(this, "hummingbird/__init__.py"), "r") as f:
line = [_ for _ in [_.strip("\r\n ") for _ in f.readlines()] if _.startswith("__version__")]
if len(line) > 0:
version_str = line[0].split("=")[1].strip('" ')
Expand Down Expand Up @@ -44,9 +44,6 @@
setup(
name="hummingbird-ml",
version=version_str,
description="Convert trained traditional machine learning models into tensor computations",
long_description=long_description,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello thanks for your PR! The goal is not to delete this text entirely, but to make it legal with the new-style setup.py files. Something like this:

Screenshot 2024-03-11 at 10 01 18 AM

Copy link
Contributor

@ksaur ksaur Mar 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment in the issue "For now just deleted these 3 lines, but we should change the format away from markdown. See docs" ... Thanks!!

long_description_content_type="text/markdown",
license="MIT License",
author="Microsoft Corporation",
author_email="[email protected]",
Expand Down
Loading