-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing services to reduce (down to 0) the skipped tests #15
Comments
Have just added 4 PRs that should be merged in order: #11 - tiny change to better detect the script directory. Same approach we use in a lot of local_ci scripts, enable you to wrap it in other, caller scripts... Ciao :-) PS: Have just launched this with all the above applied (testing branch). There should be only mlbackend, unoconv and uuid skipped tests once it finishes. Edited, yay! Down from 51 skipped tests to only 13! |
All looking good and merged \o/ |
Thanks for merging, @andrewnicols ! If you don't mind, I'm going to keep this open to take a look to the pending stuff:
And linking this with moodlehq/moodle-docker#110 that is aiming for exactly the same, but from moodle-docker. |
With the 6 PRs above all our (non-EOL) images should get uuid tests passing. So, remaining:
Ciao :-) |
With #73 merged, now the only remaining tests are:
Ciao :-) |
Uhm... was revisiting this to see if finally can get it closed... and I've just seen that phpunit is still skipping the mlbackend_python tests: https://ci.moodle.org/view/B%20-%20master/job/W.01.01%20-%20PHPUnit%20-%20Postgres/2183/console I thought we were running them... looking... |
^^^ False alarm, they are supported and running. But we only run them within the MariaDB jobs (see those jobs are named: So, only remaining test continues being:
Ciao :-) |
This issue is about to reduce the number of skipped tests with phpunit. Namely:
Basically, that's all we need to get all tests passing. Let's use this issue as epic to control it.
Ciao :-)
The text was updated successfully, but these errors were encountered: