Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to run the python mlbackend analytics tests #73

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Apr 5, 2022

Disabled by default, just define MLBACKEND_PYTHON_VERSION
with a correct tag of the docker image and that will make
the container to run and the PHPUnit jobs to use it. Example:

export MLBACKEND_PYTHON_VERSION=3.0.4-python3.7.5

This it the first step towards adding these tests to CI.

The idea is to enable it in some jobs, not all. So we have it continuously covered.

This can be considered part of #15

Ciao :-)

Disabled by default, just define `MLBACKEND_PYTHON_VERSION`
with a correct tag of the docker image and that will make
the container to run and the PHPUnit jobs to use it. Example:

export MLBACKEND_PYTHON_VERSION=3.0.4-python3.7.5

This it the first step towards adding these tests to CI.
Copy link
Contributor

@junpataleta junpataleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Eloy!

@junpataleta junpataleta merged commit 1499e43 into moodlehq:master Apr 5, 2022
@stronk7 stronk7 deleted the add_ml_python branch April 5, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants