Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bigIntToBuffer for numbers that start 0x9 #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Timmmm
Copy link

@Timmmm Timmmm commented Aug 20, 2020

Numbers that start 0x9... did not have '00' prepended.

Fixes #163

Probably a good idea to add a unit test for this function! I don't have time at the moment though, sorry.

Numbers that start 0x9... did not have '00' prepended.

Fixes mscdex#163
@dylanh724
Copy link

What's going on with this? How come it's not yet accepted?

@mscdex
Copy link
Owner

mscdex commented Oct 16, 2020

@dylanh724 ssh2 is undergoing a rewrite that no longer depends on this project, so all effort is now being spent there.

@dylanh724
Copy link

cheers

@Timmmm
Copy link
Author

Timmmm commented Oct 16, 2020

Please can you merge this in the mean time - looking forward to the rewrite but presumably that is some way off?

If you don't want the hassle I am willing to maintain this repo until your rewrite is ready.

@dylanh724
Copy link

dylanh724 commented Oct 22, 2020

Please can you merge this in the mean time - looking forward to the rewrite but presumably that is some way off?

If you don't want the hassle I am willing to maintain this repo until your rewrite is ready.

This would rock. This is a breaking bug for all those that use it, both directly and indirectly. I'm actually surprised it wasn't already since it's a 1-liner.

@allinws
Copy link

allinws commented Oct 7, 2021

Also having issue with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenSSH private keys not decoded correctly
4 participants