-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve codemod for v7 #11650
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,14 +33,14 @@ You can either run it on a specific file, folder, or your entire codebase when c | |
|
||
```bash | ||
// Date and Time Pickers specific | ||
npx @mui/x-codemod v7.0.0/pickers/preset-safe <path> | ||
npx @mui/x-codemod@next v7.0.0/pickers/preset-safe <path> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as #11521 (comment) |
||
|
||
// Target Data Grid as well | ||
npx @mui/x-codemod v7.0.0/preset-safe <path> | ||
npx @mui/x-codemod@next v7.0.0/preset-safe <path> | ||
``` | ||
|
||
:::info | ||
If you want to run the transformers one by one, check out the transformers included in the [preset-safe codemod for pickers](https://github.com/mui/mui-x/blob/master/packages/x-codemod/README.md#preset-safe-for-pickers-v700) for more details. | ||
If you want to run the transformers one by one, check out the transformers included in the [preset-safe codemod for pickers](https://github.com/mui/mui-x/blob/HEAD/packages/x-codemod/README.md#preset-safe-for-pickers-v700) for more details. | ||
::: | ||
|
||
Breaking changes that are handled by this codemod are denoted by a ✅ emoji in the table of contents on the right side of the screen. | ||
|
@@ -75,7 +75,7 @@ And are removed from the v7. | |
If not already done, this modification can be handled by the codemod | ||
|
||
```bash | ||
npx @mui/x-codemod v7.0.0/pickers/ <path> | ||
npx @mui/x-codemod@next v7.0.0/pickers/ <path> | ||
``` | ||
|
||
Take a look at [the RFC](https://github.com/mui/material-ui/issues/33416) for more information. | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong link. I think we want to always point to the latest active codebase, so HEAD.