[docs] Improve codemod for v7 #11650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| If you want to run the codemods one by one, check out the codemods included in the [preset-safe codemod for data grid](https://github.com/mui/mui-x/blob/master/packages/x-codemod/README.md#preset-safe-for-data-grid-v700) for more details. | ||
| If you want to run the codemods one by one, check out the codemods included in the [preset-safe codemod for data grid](https://github.com/mui/mui-x/blob/HEAD/packages/x-codemod/README.md#preset-safe-for-data-grid-v700) for more details. |
There was a problem hiding this comment.
Wrong link. I think we want to always point to the latest active codebase, so HEAD.
| npx @mui/x-codemod v7.0.0/pickers/preset-safe <path> | ||
| npx @mui/x-codemod@next v7.0.0/pickers/preset-safe <path> |
There was a problem hiding this comment.
Same as #11521 (comment)
Comment on lines
-119
to
+120
| - <DateCalendar defaultCalendarMonth={dayjs('2022-04-01')}; | ||
| + <DateCalendar referenceDate{dayjs('2022-04-01')} /> | ||
| -<DateCalendar defaultCalendarMonth={dayjs('2022-04-01')}; | ||
| +<DateCalendar referenceDate{dayjs('2022-04-01')} /> |
There was a problem hiding this comment.
The format with the space looks weird. Same reason why we write:
console.log(foo);and not:
console.log(foo);| + cellSelection | ||
| - cellSelectionModel={{ 0: { id: true, currencyPair: true, price1M: false } }} |
There was a problem hiding this comment.
Missing unstable_
|
I opened a PR rather than pushing straight to HEAD to make sure this passes the CI. These changes are straightforward, merging. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.