Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(castable-video): Add castCustomData to send arbitrary custom data to receiver app on load. #32

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

cjpillsbury
Copy link
Contributor

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-elements-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 2:51pm

'webkitExitFullScreen',
'webkitExitFullscreen',
'webkitVideoDecodedByteCount',
// Commenting browser-prefixed properties out as we should not
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This is unrelated but tests were failing both locally and on GHA because some webkit browser-prefixed fullscreen props were not present in the browser version used for testing.

@cjpillsbury cjpillsbury requested a review from luwes August 13, 2024 14:48
Copy link
Collaborator

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjpillsbury cjpillsbury merged commit fc25a3b into main Aug 13, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Aug 13, 2024
cjpillsbury added a commit to muxinc/elements that referenced this pull request Aug 13, 2024
* Exposes `castReceiver` / `cast-receiver` prop / attr to specify a
custom receiver app
* Adds mux-specific custom data for a custom Google Chromecast receiver
app (minimally necessary for DRM license requests).
* Adds `drmType` to Mux Data metadata once the DRM type is determined
via key session initialization.
* Relates to muxinc/media-elements#32
* Ensures omitted storyboard tokens and thumbnail tokens don't cause
errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants