Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent time conductor related handling for plot synchronization. #7956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Dec 11, 2024

Closes #7737

Describe your changes:

Ensure that the mode set when independent time conductor is enabled/disabled is propagated correctly.

Also ensure that global time conductor changes are not picked up by the independent time conductor when the user has enabled it at least once before

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

…isabled is propagated correctly.

Also ensure that global time conductor changes are not picked up by the independent time conductor when the user has enabled it at least once before
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.32%. Comparing base (5be103e) to head (5094c19).

Files with missing lines Patch % Lines
src/api/time/IndependentTimeContext.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7956      +/-   ##
==========================================
+ Coverage   57.57%   65.32%   +7.74%     
==========================================
  Files         678      436     -242     
  Lines       27428    13648   -13780     
  Branches     2691        0    -2691     
==========================================
- Hits        15793     8915    -6878     
+ Misses      11294     4733    -6561     
+ Partials      341        0     -341     
Flag Coverage Δ
e2e-ci 62.77% <83.33%> (-0.05%) ⬇️
e2e-full 41.97% <16.66%> (+<0.01%) ⬆️
unit ?
Files with missing lines Coverage Δ
src/api/time/TimeAPI.js 91.17% <100.00%> (+0.26%) ⬆️
src/api/time/IndependentTimeContext.js 68.75% <80.00%> (-13.19%) ⬇️

... and 365 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be103e...5094c19. Read the comment docs.

@unlikelyzero
Copy link
Collaborator

@shefalijoshi i think the best test is the first example of steps to reproduce:

No fixed time change warning prompt

Create an overlay plot, add telemetry to it, and save
View the plot in realtime mode
hover over the plot and click Pause
hover over the plot and click Synchronize with Time Conductor
Observe you get a warning message and are switched to Fixed time mode (This is expected behavior)
Toggle the independent time conductor, then toggle the indepedent time conductor off
Change the time conductor back to realtime mode.
Repeat steps 4 and 5 to pause and sync time with conductor
Observe this time there is no warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plots are respecting independent time context settings, even if not enabled
2 participants