Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Callout - Fix Types #3

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Auth Callout - Fix Types #3

merged 3 commits into from
Aug 9, 2024

Conversation

rickdotnet
Copy link
Collaborator

Two types in particular prevented me from properly responding to auth callout in non-operator mode. This PR contains the adjustments that enabled a successful response.

Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @rickdotnet

Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question about the id

NATS.Jwt/Models/NatsClientInformation.cs Outdated Show resolved Hide resolved
@mtmk mtmk self-requested a review August 9, 2024 13:00
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 5a977ad into nats-io:main Aug 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants